Uncomment resolutions of applied LWG issues#3461
Uncomment resolutions of applied LWG issues#3461StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
a7633f9 to
02e547b
Compare
Covers: * LWG-3085 * LWG-3664 * LWG-3723 * LWG-3742 * LWG-3807 * LWG-3857 * LWG-3867 I've verified that we completely implement the resolutions of these issues. Drive-by: remove extraneous `()` in the constraints on `basic_string_view`'s range constructor.
02e547b to
e068a97
Compare
strega-nil-ms
left a comment
There was a problem hiding this comment.
This is missing changes in:
tests/libcxx/expected_results.txt:623tests/libcxx/skipped_tests.txt:623tests/std/tests/P0220R1_string_view/test.cpp:376
diff --git a/tests/libcxx/expected_results.txt b/tests/libcxx/expected_results.txt
index dcb235da..bf43ff99 100644
--- a/tests/libcxx/expected_results.txt
+++ b/tests/libcxx/expected_results.txt
@@ -620,7 +620,7 @@ std/language.support/support.limits/support.limits.general/format.version.compil
# libc++ doesn't yet implement LWG-3670
std/ranges/range.factories/range.iota.view/iterator/member_typedefs.compile.pass.cpp FAIL
-# libc++ doesn't speculatively implement LWG-3857
+# libc++ doesn't yet implement LWG-3857
std/strings/string.view/string.view.cons/from_range.pass.cpp FAIL
std/strings/string.view/string.view.cons/from_string1.compile.fail.cpp FAIL
std/strings/string.view/string.view.cons/from_string2.compile.fail.cpp FAIL
diff --git a/tests/libcxx/skipped_tests.txt b/tests/libcxx/skipped_tests.txt
index 6f494826..95e3cc63 100644
--- a/tests/libcxx/skipped_tests.txt
+++ b/tests/libcxx/skipped_tests.txt
@@ -620,7 +620,7 @@ language.support\support.limits\support.limits.general\format.version.compile.pa
# libc++ doesn't yet implement LWG-3670
ranges\range.factories\range.iota.view\iterator\member_typedefs.compile.pass.cpp
-# libc++ doesn't speculatively implement LWG-3857
+# libc++ doesn't yet implement LWG-3857
strings\string.view\string.view.cons\from_range.pass.cpp
strings\string.view\string.view.cons\from_string1.compile.fail.cpp
strings\string.view\string.view.cons\from_string2.compile.fail.cpp
diff --git a/tests/std/tests/P0220R1_string_view/test.cpp b/tests/std/tests/P0220R1_string_view/test.cpp
index 78324c1c..0484c73d 100644
--- a/tests/std/tests/P0220R1_string_view/test.cpp
+++ b/tests/std/tests/P0220R1_string_view/test.cpp
@@ -373,7 +373,6 @@ constexpr bool test_case_range_constructor() {
static_assert(!is_convertible_v<string_view, basic_string_view<char, constexpr_char_traits>>);
static_assert(!is_convertible_v<basic_string_view<char, constexpr_char_traits>, string>);
- // LWG-3857 basic_string_view should allow explicit conversion when only traits vary
static_assert(is_constructible_v<string_view, basic_string<char, constexpr_char_traits>>);
static_assert(is_constructible_v<basic_string_view<char, constexpr_char_traits>, string_view>);
These are fixed in #3464. (I did some more extensive edits to these files, and wanted to avoid merge conflicts, so I left them alone in this PR.)
Yeow - fixed. (I audited for other missed occurrences of all the pertinent LWG issues, and only found the mentions of LWG-3857 in the skip files you mention above.) |
|
I am neutral on the |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
|
Covers:
I've verified that we completely implement the resolutions of these issues.
Drive-by: remove extraneous
()in the constraints onbasic_string_view's range constructor.